Skip to content

Should goog.DEBUG be false for builds distributed via npm? #9

Open
@tatethurston

Description

@tatethurston

goog.DEBUG is true in the google-protobuf.js runtime distributed in the npm package. This setting gates the various assertion code in the runtime (goog.asserts.ENABLE_ASSERTS = goog.DEBUG;).

  1. Is this expected?
  2. If so, should DEBUG be set to false for production builds? And should two builds be distributed, or a means be exposed to configure this?
  3. If not, should the gulpfile that generates the runtime supply --define goog.DEBUG=false to the closure compiler invocation?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions