Close DB connection after probe completes. #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… leak Signed-off-by: Kurtis Bass <[email protected]>
|
Can anybody process this pr? |
|
@SuperQ Can you help to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently each probe creates a new DB connection which is never closed. This fix closes the connection upon the completion of a probe. An alternative solution would be to inject a DB object into the handleProbe handler, but that would be a larger scope change.
Tested locally and scrapes correctly without increasing the number of connections in Postgres.
edit: since opening the PR I have been running this in a dev environment and scrapes are working as expected and connection level is staying stable.
Will fix #727
Signed-off-by: Kurtis Bass [email protected]