-
Notifications
You must be signed in to change notification settings - Fork 769
Fix broken log-level for values other than debug. #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken log-level for values other than debug. #560
Conversation
Signed-off-by: Harkishen Singh <[email protected]>
fab5c6a
to
c1ab341
Compare
I think the change to the new |
@sysadmind the changes in this PR were inspired from node_exporter's way of implementing logging. That's how I got it fixed. |
github.com/go-kit/log is the new one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@roidelapluie please approve or give an advice how to fix it another way. The whole journald is full of debug logs because of this bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As go-kit#1173 mentioned
Anyone in @prometheus-community/postgres_exporter have time to approve/merge this? There's a rather high overhead right now, with every scrape in default configuration logging roughly 1kb. |
would be great to have this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done according to go-kit/kit#1173
@SuperQ, could you please approve this? Due to high amount of logs for many db clusters, we're seeing a significant increase in our logging ingestion costs. |
Any news here? We face the same problem like @ppihus. Filter logs on ingest is possible but nasty. |
@wrouesnel , @SuperQ , we're seeing the same issue and had to downgrade to 0.9.x. Is there anything that can be done to move this one along? |
Looks like this project is abandond :-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, sorry for delay in reviewing.
Sorry, I've been very busy with things and have not had the time to keep up with work on this exporter. And I really should, since my $dayjob has a bunch of PG servers. |
* [BUGFIX] Fix broken log-level for values other than debug. #560 Signed-off-by: SuperQ <[email protected]>
* [BUGFIX] Fix broken log-level for values other than debug. #560 Signed-off-by: SuperQ <[email protected]>
* [BUGFIX] Fix broken log-level for values other than debug. #560 Signed-off-by: SuperQ <[email protected]>
* [BUGFIX] Fix broken log-level for values other than debug. #560 Signed-off-by: SuperQ <[email protected]>
Work can be absorbing. ;-) It's good that everything is OK with your health. |
* [BUGFIX] Fix broken log-level for values other than debug. prometheus-community#560 Signed-off-by: SuperQ <[email protected]> Signed-off-by: Angus Dippenaar <[email protected]>
* [BUGFIX] Fix broken log-level for values other than debug. prometheus-community#560 Signed-off-by: SuperQ <[email protected]> Signed-off-by: Angus Dippenaar <[email protected]>
…log-level Fix broken log-level for values other than debug.
* [BUGFIX] Fix broken log-level for values other than debug. prometheus-community#560 Signed-off-by: SuperQ <[email protected]>
Signed-off-by: Harkishen Singh [email protected]
Fixes: #557