Skip to content

feat(mixin): Add grafana mixins support for postgres exporter #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

kavirajk
Copy link
Contributor

@kavirajk kavirajk force-pushed the grafana_mixin branch 4 times, most recently from efaf1dc to b26962e Compare October 16, 2020 12:04
@coveralls
Copy link

coveralls commented Oct 16, 2020

Coverage Status

Coverage remained the same at 64.7% when pulling fa90aaf on kavirajk:grafana_mixin into b12c8ab on wrouesnel:master.

@kavirajk
Copy link
Contributor Author

/cc @wrouesnel

@jeschkies
Copy link

@wrouesnel, what do you think? Could this be merged 🙂

@SuperQ
Copy link
Contributor

SuperQ commented Mar 1, 2021

Would you please rebase this against the latest revision? It should kick off updated tests.

@kavirajk kavirajk force-pushed the grafana_mixin branch 2 times, most recently from a17848b to c3c4434 Compare March 2, 2021 12:40
@kavirajk
Copy link
Contributor Author

kavirajk commented Mar 2, 2021

@SuperQ rebased!

@matthiasantierens
Copy link

Did you already look at this dashboard? (https://github.com/lstn/misc-grafana-dashboards) It looks more complete 😃, Could we combine them?

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks! More mixins!

@SuperQ SuperQ merged commit 283a2a3 into prometheus-community:master Mar 3, 2021
ritbl pushed a commit to heniek/postgres_exporter that referenced this pull request Mar 19, 2023
feat(mixin): Add grafana mixins support for postgres exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants