update to use common/log #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Definitely something we want to do. Merged. |
| @@ -330,7 +327,7 @@ func dbToFloat64(t interface{}) (float64, bool) { | |||
| case string: | |||
| result, err := strconv.ParseFloat(v, 64) | |||
| if err != nil { | |||
| log.Println("Could not parse string:", err) | |||
| log.Infoln("Could not parse string:", err) | |||
There was a problem hiding this comment.
All of these should be Errorln (or maybe Warnln).
dehaansa
pushed a commit
to dehaansa/postgres_exporter
that referenced
this pull request
Oct 24, 2024
…-use-deprecated-method Do not use deprecated method github.com/prometheus/common/version.NewCollector
Sticksman
added a commit
to Sticksman/postgres_exporter
that referenced
this pull request
Apr 24, 2025
…unity#18) * ci(.drone.yml): convert spinnaker pipelines to drone * Add trigger --------- Co-authored-by: Felix Yuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.