Feature queries from file #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! I'll review and merge asap. |
|
👍 Thanks! |
|
Done. Btw, the yaml metric is a custom one we use, so it would probably make sense to update queries.yaml to have names that closely reflect the Pg admin functions. |
|
I found an issue with noushi's PR so I created a PR on it (noushi#1), not sure if that's the right way to do it? Just thought I'd mention it here so that you incorporate the fix when you merge this PR, in case noushi hasn't done so himself. |
|
Thank you @wrouesnel @ncabatoff . |
dehaansa
pushed a commit
to dehaansa/postgres_exporter
that referenced
this pull request
Oct 24, 2024
Sticksman
pushed a commit
to Sticksman/postgres_exporter
that referenced
this pull request
Apr 24, 2025
…pc_deployment Separate k8s vpc deployment for postgres-exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @wrouesnel ,
This PR adds support for custom queries in an external YAML file.
SHOW variables are not supported yet.
It should help close #1 .
I've deployed it yesterday and we're successfully getting metrics from our 54 Postgres replicas.