Skip to content

Add more ENV variables #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Jan 30, 2018 · 1 comment
Closed

Add more ENV variables #150

ghost opened this issue Jan 30, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Jan 30, 2018 •
edited by ghost
Loading

Hi:

Please, add the possibility that flags web.telemetry-path and web.listen-address could be fetched from an env variables too and not only from flags.

BTW, include in the documentation the default values for web.telemetry-path and web.listen-address

Change the default values for web.listen-address FROM :9187 to 0.0.0.0:9187

listenAddress = kingpin.Flag("web.listen-address", "Address to listen on for web interface and telemetry.").Default(":9187").String()

Regards
wrouesnel added a commit that referenced this issue Feb 19, 2018
@wrouesnel
Add environment variable control for most command line options.
5722b6d 
Adds the following environment variables for overriding defaults:
* `PG_EXPORTER_WEB_LISTEN_ADDRESS`
* `PG_EXPORTER_WEB_TELEMETRY_PATH`
* `PG_EXPORTER_EXTEND_QUERY_PATH`

Closes #150.
wrouesnel added a commit that referenced this issue Feb 19, 2018
@wrouesnel
Add environment variable control for most command line options.
e591b87 
Adds the following environment variables for overriding defaults:
* `PG_EXPORTER_WEB_LISTEN_ADDRESS`
* `PG_EXPORTER_WEB_TELEMETRY_PATH`
* `PG_EXPORTER_EXTEND_QUERY_PATH`

Closes #150.
@ghost
Copy link
Author

ghost commented Feb 20, 2018

Thanks so much

ritbl referenced this issue in heniek/postgres_exporter Mar 19, 2023
@wrouesnel
Add environment variable control for most command line options.
283e4f0 
Adds the following environment variables for overriding defaults:
* `PG_EXPORTER_WEB_LISTEN_ADDRESS`
* `PG_EXPORTER_WEB_TELEMETRY_PATH`
* `PG_EXPORTER_EXTEND_QUERY_PATH`

Closes percona#150.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants