This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Re-implement "improve this content button" #320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since prose/prose#643 has remained unresolved since early December, this pull request swaps out the Prose-based "Help Improve this content" button, for one that links directly to GitHub's editing interface.
Although admittedly not ideal, I'd argue that a working button that allows the user to complete their designated task is superior to a button that doesn't work but has a more user-friendly interface.
The flow for authenticated users will now be:
The flow for unauthenticated users
User will be asked to login to or signup for GitHub, and then flow will be the same as above.
Fixes #315, /cc @lukefretwell, @leahbannon
Full Disclosure: I'm a GitHub employee who hates bugs and ❤️'s user-friendly experiences, even for the uninitiated.