Theme

[awolfe76]

Contributing the best way I know how. Hope you don't mind.

Created a new theme for the site, nothing major, just maybe a little more readable, with a mobile first approach.

I think I caught everything, a lot more content then I initially realized.

Nice work by the way!

[benbalter]

@andrew-wolfe Thanks for taking the time to package as a Pull Request. Are you able to attach a few screenshots to this thread by chance? It would really help others join the discussion without having to spin things up locally. You should just be able to drag and drop into the comment field.

[benbalter]

Also, looping in @dannychapman who was the mastermind behind the first pass.

[awolfe76]

Good idea. Here are 2, the home page. Hopefully enough to start the conversation, but if we need more can definitely add them.

[benbalter]

Wow. This looks awesome. There were a handful of formatting tweaks in main.css for the policymemo... did those make it over by chance (or something similar)?

[benbalter]

also cc @project-open-data/project-open-data-web ... any thoughts on the above proposed design improvements?

[awolfe76]

Yeah, I brought them over. Seem right? I'm pretty sure I caught everything.

And that's a really handy way to point to specific lines ... that I didn't know you could do. So thanks for that too!

[waldoj]

Having a responsive design is a huge win. I see no reason not to merge this.

[awolfe76]

And would you guys rather receive pull requests with a branch or on master? I branched locally but merged before submitting the request.

[benbalter]

Spun it up locally and clicked around – awesome, awesome work. ❤️

Would love to hold off for a bit to give @dannychapman a chance to weigh in if he wants, but otherwise 👍 from me.

@awolfe76 pointing at master here is the right way to go. Generally speaking, best practices dictate that you'd make a feature branch on your fork, and submit the pull from your feature branch to master of the original repo. That way, your master stays clean, and if while this Pull Request is pending, you want to submit another pull request, you can easily do so by re-branching off of master with a new feature branch and can submit as they can easily be merged down the line.

[benbalter]

What's the reason for the change here?

[awolfe76]

Nothing really. It wasn't being used in the template before, and I just don't like to type whole words. :)

[awolfe76]

If we go at it again I'll submit with a branch for sure.

[parkr]

👍 This looks great.

[dannychapman]

Looks good to me - thanks for looping me in @benbalter! Great work @awolfe76. Let's merge.

[benbalter]

👍

[benbalter]

@dannychapman Don't know that FLOTUS is going to be launching a "let's merge" campaign any time soon... but pull requests welcome.

[awolfe76]

@benbalter @parkr @dannychapman Thanks!

And just realized @andrew-wolfe, yep that's me and @awolfe76, yep that's me too. 😕 Sorry about that.

"Let's Merge" - I do feel a campaign coming on (and a great geek pickup line).

[stevenvdc]

@awolfe76 Thanks so much for the contribution to Project Open Data! The new theme looks great-- love the responsive design aspects. Merging your pull request now... 🇺🇸

- Steve VanRoekel, US Chief Information Officer

[ErieMeyer]

[benbalter]

[andrew-wolfe]

@stevenvdc Thank you. Looking forward to more from Project Open Data. A great first step.