This repository was archived by the owner on Jun 18, 2024. It is now read-only.
This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Feedback on common core schema #49
Closed
Description
In general, great work! A few questions/comments:
contactPoint
is being added to DCAT. To maintain conformance, consider renaming theperson
property tocontactPoint
.- I prefer
schema:email
tofoaf:mbox
, but either is fine. Just letting you know that you can call that propertyemail
as the two properties areowl:sameAs
, I believe. DidsystemOfRecords
come from an existing vocabulary, or did you need to mint it for your use case? If it is new, it would be good practice to mention it, as you've done foraccessLevel
.- fixed Updated schema.md #60
dcat:size
has been renamed todcat:byteSize
, which is a clearer term. As mentioned in corrected file size to proper use of B vs b and M/G vs m/g #32, byte size is much less prone to error than various abbreviations for byte size, like GB, GiB, etc.size
has been removed 🔥 the size field #114
- Dublin Core has a different, more flexible way of expressing
dct:temporal
. You may want to consider making it an object with "start" and "end" fields. This would also solve Suggested formatting around allowing open ranges for the temporal property #43 FYI,granularity
was dropped from DCAT because it was underspecified and publishers simply didn't know how/when/why to use it. You may want to drop it as well unless you have a very clear use case in mind (that others share).- fixed Drop granularity #115
dataDictionary
was also dropped due to inconsistent usage.dataQuality
was dropped from DCAT for similar reasons, but I see you have a clear definition of what it means, so it makes sense to keep that one. Just flagging these to let you know that you can very likely get rid of them if you were already on the fence about them.WebService
andFeed
are classes in DCAT (subclasses of Distribution to be specific), not properties. To be consistent, you can have a@type
field (see DCAT JSON structure #23 for why this term should be used) on each Distribution which would be used to say whether the distribution is a WebService, Feed or Download. This also solves the issue of having multiple APIs and feeds for the same dataset, which is not handled by the current spec.- As mentioned in Need consistent JSON serialization for properties with (0,n) + (1,n) cardinality #39, please use arrays and not comma-separated values.
- It would be cool to add the three properties mentioned in DCAT JSON structure #23 (
@context
,@id
and@type
)