This repository was archived by the owner on Jun 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 601
Feedback on common core schema #49
Labels
Comments
Comments re: ranges:
Other comments:
JSON errors:
|
FYI, DCAT is transitioning to Candidate Recommendation (CR) at W3C - most of the changes to DCAT mentioned above happened over the last year before this repository was published. Also, I don't mind writing pull requests for these; I figure it's best to discuss first. |
This was referenced May 16, 2013
Merged
Merged
👍 for dropping granularity, implemented in #115 |
Thanks for all of your hard work on this!
I think that closes out any outstanding issues here. Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In general, great work! A few questions/comments:
contactPoint
is being added to DCAT. To maintain conformance, consider renaming theperson
property tocontactPoint
.schema:email
tofoaf:mbox
, but either is fine. Just letting you know that you can call that propertyemail
as the two properties areowl:sameAs
, I believe.DidsystemOfRecords
come from an existing vocabulary, or did you need to mint it for your use case? If it is new, it would be good practice to mention it, as you've done foraccessLevel
.dcat:size
has been renamed todcat:byteSize
, which is a clearer term. As mentioned in corrected file size to proper use of B vs b and M/G vs m/g #32, byte size is much less prone to error than various abbreviations for byte size, like GB, GiB, etc.size
has been removed 🔥 the size field #114dct:temporal
. You may want to consider making it an object with "start" and "end" fields. This would also solve Suggested formatting around allowing open ranges for the temporal property #43FYI,granularity
was dropped from DCAT because it was underspecified and publishers simply didn't know how/when/why to use it. You may want to drop it as well unless you have a very clear use case in mind (that others share).dataDictionary
was also dropped due to inconsistent usage.dataQuality
was dropped from DCAT for similar reasons, but I see you have a clear definition of what it means, so it makes sense to keep that one. Just flagging these to let you know that you can very likely get rid of them if you were already on the fence about them.WebService
andFeed
are classes in DCAT (subclasses of Distribution to be specific), not properties. To be consistent, you can have a@type
field (see DCAT JSON structure #23 for why this term should be used) on each Distribution which would be used to say whether the distribution is a WebService, Feed or Download. This also solves the issue of having multiple APIs and feeds for the same dataset, which is not handled by the current spec.@context
,@id
and@type
)Ref.: the latest version of DCAT
The text was updated successfully, but these errors were encountered: