Skip to content
This repository was archived by the owner on Jun 18, 2024. It is now read-only.

Capitalization for PrimaryITInvestmentUII is inconsistent #284

Closed
philipashlock opened this issue Mar 4, 2014 · 9 comments
Closed

Capitalization for PrimaryITInvestmentUII is inconsistent #284

philipashlock opened this issue Mar 4, 2014 · 9 comments

Comments

@philipashlock
Copy link
Contributor

The capitalization for PrimaryITInvestmentUII is inconsistent with the rest of the schema.

All other fields in the schema (and DCAT) use lower camel case (first word lowercase and all other words with the first letter capitalized). Based on this field and accessURL there seems to be a convention to maintain capitalization on all abbreviations as well, so I guess that's fine here.

Instead this should be primaryITInvestmentUII

@MarionRoyal
Copy link

@philipashlock
I agree that we should be consistent in using lower camel case since the majority of our metadata uses that syntax, especially if we are inventing attributes not found in other namespaces.
I'm not sure what value the acronyms (IT and UII) bring to the business term of primaryInvestment.

@philipashlock
Copy link
Contributor Author

@MarionRoyal the acronyms come from the guidance on "Exhibits 53 and 300 series" in that they refer to a Unique Investment Identifier (UII) for agency information technology (IT) projects. There's more context and some links on #282 and the original discussion was on #91

@MarionRoyal
Copy link

+1

Marion A. Royal
202.302.4634

Sent from PDA

On Mar 4, 2014, at 5:21 PM, Philip Ashlock [email protected] wrote:

The capitalization for PrimaryITInvestmentUII is inconsistent with the rest
of the schema.

All other fields in the schema (and DCAT) use lower camel case (first word
lowercase and all other words with the first letter capitalized). Based on
this field and accessURL there seems to be a convention to maintain
capitalization on all abbreviations as well, so I guess that's fine here.

Instead this should be primaryITInvestmentUII

Reply to this email directly or view it on
GitHubhttps://github.com//issues/284
.

@gbinal
Copy link
Contributor

gbinal commented Apr 14, 2014

+1

@philipashlock philipashlock added this to the Next Version of Common Core Metadata Schema milestone Apr 14, 2014
@haleyvandyck haleyvandyck modified the milestone: Next Version of Common Core Metadata Schema Apr 14, 2014
@philipashlock philipashlock modified the milestone: Next Version of Common Core Metadata Schema Apr 14, 2014
@haleyvandyck
Copy link
Contributor

Thanks for catching this @philipashlock. Making this consistent seems logical. We've added this to the list to consider with the next version of the schema. In the meantime, would you mind submitting a pull request? Thanks!

@philipashlock philipashlock modified the milestone: Next Version of Common Core Metadata Schema (1.0 -> 1.1.) Jul 24, 2014
haleyvandyck pushed a commit that referenced this issue Jul 24, 2014
this resolves issue #284 - Capitalization for PrimaryITInvestmentUII is inconsistent
@philipashlock
Copy link
Contributor Author

As @haleyvandyck's pull request (#344) indicates the plan is to apply this change to the new version of the schema and leave the original 1.0 version untouched.

@gbinal
Copy link
Contributor

gbinal commented Aug 22, 2014

gbinal added a commit that referenced this issue Sep 8, 2014
@gbinal
Copy link
Contributor

gbinal commented Sep 8, 2014

This is addressed by 9b15ac4

@gbinal
Copy link
Contributor

gbinal commented Nov 7, 2014

Thank you for driving the conversation around this issue and helping to assemble the v1.1 metadata update.

There appears to be strong consensus around this issue, which has been accepted in the v1.1 update and merged into Project Open Data. Project Open Data is a living project though. Please continue any conversations around how the schema can be improved with new issues and pull requests!

It's important for government staff as well as the public to continue to collaborate to make the Open Data Policy ever better. Though the v1.1 update is a substantial update, future iterations do not have to be, so whatever your ideas - big or small - please continue to work with this community to improve how government manages and opens its data.

@gbinal gbinal closed this as completed Nov 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants