Skip to content

adding node 18 #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 8, 2022
Merged

adding node 18 #711

merged 5 commits into from
Aug 8, 2022

Conversation

Janther
Copy link
Contributor

@Janther Janther commented Aug 3, 2022

No description provided.

@Janther Janther requested review from mattiaerre and fvictorio August 3, 2022 04:06
@fvictorio
Copy link
Member

I'm not sure about this. Node 14 is in "Security support" maintenance mode (https://endoflife.date/nodejs), which to me means that it hasn't EOLed yet. We still support it in Hardhat, for example (this is our policy).

@Janther
Copy link
Contributor Author

Janther commented Aug 3, 2022

Fair enough.
I'll add 18 to the github actions though

@Janther Janther changed the title dropping node 14 adding node 18 Aug 3, 2022
@fvictorio
Copy link
Member

Which version of npm are you using? Just curious about some fields of the package-lock.json being dropped after it's converted to lockfileVersion 2.

@Janther
Copy link
Contributor Author

Janther commented Aug 3, 2022

the package.log was generated using npm 6.14.13 which is the version that came with nvm use 14
I found it interesting that that the file changed so much so I redid the process and the file size wen't back to lockfileVersion 1.

@Janther Janther merged commit b335d24 into main Aug 8, 2022
@Janther Janther deleted the node-16 branch August 8, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants