Skip to content

Preact-cli next support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2019
Merged

Preact-cli next support #3

merged 1 commit into from
Apr 10, 2019

Conversation

mseddon
Copy link
Contributor

@mseddon mseddon commented Apr 10, 2019

Fix up some dependencies for preact-cli@next.

Notably we need to depend on "css-loader": "^1.0.1", due to Jimdo/typings-for-css-modules-loader#89.

@types/webpack-env prevents vscode from whining about the use of module in app.tsx.

ForsakenHarmony
ForsakenHarmony approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForsakenHarmony
Copy link
Contributor

Thanks 🎉

@ForsakenHarmony ForsakenHarmony merged commit 95bb89c into preactjs-templates:master Apr 10, 2019
rschristian pushed a commit that referenced this pull request Jul 18, 2022
@ForsakenHarmony
Merge pull request #3 from mseddon/next
e2777a3 
Preact-cli next support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mseddon @ForsakenHarmony