shallow equality check before Plotly.react #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| nextProps.config === this.props.config && | ||
| nextProps.frames === this.props.frames) | ||
| ) { | ||
| return; |
There was a problem hiding this comment.
Why the move from shouldComponentUpdate to componentWilUpdate?
There was a problem hiding this comment.
clearly I didn't read you initial comment... disregard
bpostlethwaite
approved these changes
Mar 7, 2018
|
Yes but then the component wouldn't rerender the div if e.g. the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the revision check out of
shouldComponentUpdatebecause it's not "just an optimization" and also does a partial shallow equality check on props to skip callingPlotly.reactif nothing has changed to avoid infinite loops.