various fixes for event addition/removal #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaskruchten
commented
Feb 20, 2018
| @@ -135,32 +135,6 @@ describe('<Plotly/>', () => { | |||
| .catch(err => done.fail(err)); | |||
| }); | |||
|
|
|||
| test('clear event handlers on newPlot', done => { | |||
There was a problem hiding this comment.
this test was way too implementation-specific and now depends on the Plotly.js version.
nicolaskruchten
commented
Feb 20, 2018
| config: nextProps.config, | ||
| frames: nextProps.frames, | ||
| }); | ||
| } | ||
| }) | ||
| .then(() => this.syncEventHandlers(nextProps)) | ||
| .then(() => this.syncWindowResize(nextProps)) | ||
| .then(this.attachUpdateEvents) | ||
| .then(() => { | ||
| if (!hasReactAPIMethod) this.attachUpdateEvents(); |
There was a problem hiding this comment.
this is the main fix
|
this looks good 💃 |
VeraZab
approved these changes
Feb 20, 2018
|
Thanks! I'll do a release after I've eaten :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42