Skip to content

fix(refs): fixed issue with referencing element of unmounted component #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

fix(refs): fixed issue with referencing element of unmounted component #200

merged 1 commit into from
Sep 11, 2020

Conversation

lavor
Copy link

@lavor lavor commented Sep 2, 2020

Fixes #199

@alexcjohnson
Copy link
Collaborator

Thanks @lavor - this looks good to me but I'd like to get either @dmt0 or @VeraZab to approve it before we merge & publish. I think they're both on holiday this week but I'll make sure we get to it when one of them gets back.

@alexcjohnson alexcjohnson requested a review from dmt0 September 2, 2020 13:32
@lavor
Copy link
Author

lavor commented Sep 2, 2020

Thanks, I will wait for it.

dmt0
dmt0 approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@dmt0 dmt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lavor!
Also I tested it with react-chart-editor - no issues.

@dmt0 dmt0 merged commit 538eac5 into plotly:master Sep 11, 2020
@lavor
Copy link
Author

lavor commented Sep 14, 2020 •
edited
Loading

Thanks, @dmt0 .
Could you release a new version with this change included, please?

@dmt0
Copy link
Contributor

dmt0 commented Sep 14, 2020

@lavor of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmt0 dmt0 dmt0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOM element provided is null or undefined
3 participants
@lavor @alexcjohnson @dmt0