Menupanel does not trigger section visibility by default #99
Conversation
| } else { | ||
| plotProps = {isVisible: true}; | ||
| // custom UI currently forces section visibility. | ||
| newProps = {key: i, 'data-section-child-visible': true}; |
There was a problem hiding this comment.
Do you have a use case in mind for this right now? I'm trying to figure out whether it seems more like <Info> or more like an attr.
There was a problem hiding this comment.
For example if you want to add a business logic component that isn't tied to the editor. A data importer component or a component that adds buttons and range sliders but doesn't have an attr
There was a problem hiding this comment.
If you add your own stuff to a Section the section will be visible. At that point it's up to the developer to add their own visibility handling.
There was a problem hiding this comment.
Makes sense, I guess the last resort clause should be to make it visible. So I guess in the most generic case you'd add plotProps with isVisible for your own custom handling?
There was a problem hiding this comment.
Yep that is exactly what CanvasSize and AxesRange and friends use by defining a modifyPlotProps function that overrides plotProps.isVisible
|
💃 I like it. |
bpostlethwaite
deleted the
menupanelDoesNotTriggerSectionVisibilityByDefault
branch
closes #58
@alexcjohnson this PR addressed earlier conversations linked in #58 we had about
<Section>visibility. Now neither<Info>or<MenuPanel>trigger automatic<Section>visibility but will be hidden along with the<Section>if noattrcomponents are defined.