Skip to content

Multi axes #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Nov 17, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
bf4376e
add back eslint to dev tooling but integrate with prettier
bpostlethwaite Nov 14, 2017
19ef73e
lint Section
bpostlethwaite Nov 14, 2017
f39568e
lint DataSelector
bpostlethwaite Nov 14, 2017
529fa60
lint Dropdown and Radio
bpostlethwaite Nov 14, 2017
953598f
css fix (lowercase)
bpostlethwaite Nov 14, 2017
02f7be2
introduce connectAxesToLayout higher order component
bpostlethwaite Nov 14, 2017
c89dc4b
introduce Axes Selector
bpostlethwaite Nov 14, 2017
a6f14c5
thread new items though index.js files
bpostlethwaite Nov 14, 2017
ee1c27c
Rewrite Numeric input to use new multivalued subsystem
bpostlethwaite Nov 14, 2017
f237701
sketch out DefaultEditor Axes panel
bpostlethwaite Nov 14, 2017
58b6904
Widgets no longer need know about multivalued at all
bpostlethwaite Nov 14, 2017
8ff079e
Dropdown handles multivalued by changing placeholder
bpostlethwaite Nov 14, 2017
60fccf0
replace all non-brand scss with brand scss. Create Info scss
bpostlethwaite Nov 15, 2017
8f24a74
PanelMenuWrapper does not need to be localized
bpostlethwaite Nov 15, 2017
4949d64
field and subpanel can be configured to handle multiValue info
bpostlethwaite Nov 15, 2017
380cc35
Info does not use propTypes
bpostlethwaite Nov 15, 2017
e4c2049
Add AxesRange component to handle special visibility
bpostlethwaite Nov 15, 2017
f51c8bb
fix for TraceSelector
bpostlethwaite Nov 15, 2017
fa5dcc5
create a more reasonable scss system
bpostlethwaite Nov 15, 2017
4b6f652
rename SubPanel -> MenuPanel and split MenuPanel
bpostlethwaite Nov 15, 2017
e573f95
delete all the unused constants
bpostlethwaite Nov 15, 2017
8afad28
small fixes for props and truthy checks in components
bpostlethwaite Nov 15, 2017
d022316
introduce SymbolSelector
bpostlethwaite Nov 15, 2017
21fb7ec
TraceMarkerSection handles naming section after trace types
bpostlethwaite Nov 16, 2017
e0e0fd5
CanvasSize
bpostlethwaite Nov 16, 2017
cf40784
pull trace handling from DefaultEditor into TraceSelector fixes #56
bpostlethwaite Nov 16, 2017
35784a4
remove requirement that plotly.js is passed into Editor fixes #86
bpostlethwaite Nov 16, 2017
274df5d
Merge pull request #87 from plotly/CanvasSize
bpostlethwaite Nov 17, 2017
fa29c2d
Merge pull request #78 from plotly/SymbolSelector
bpostlethwaite Nov 17, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/fields/Numeric.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,21 @@ import Field from './Field';
import NumericInput from '../widgets/NumericInputStatefulWrapper';
import PropTypes from 'prop-types';
import React, {Component} from 'react';
import {bem, connectToContainer} from '../../lib';
import {connectToContainer} from '../../lib';

class Numeric extends Component {
render() {
return (
<Field {...this.props}>
<NumericInput
value={this.props.fullValue()}
defaultValue={this.props.defaultValue}
step={this.props.step}
min={this.props.min}
max={this.props.max}
onChange={this.props.updatePlot}
onUpdate={this.props.updatePlot}
multiValued={this.props.multiValued}
showArrows
/>
</Field>
Expand All @@ -23,11 +25,13 @@ class Numeric extends Component {
}

Numeric.propTypes = {
defaultValue: PropTypes.number,
fullValue: PropTypes.func,
min: PropTypes.number,
max: PropTypes.number,
step: PropTypes.number,
updatePlot: PropTypes.func,
multiValued: PropTypes.bool,
...Field.propTypes,
};

Expand Down
114 changes: 0 additions & 114 deletions src/components/widgets/NumericInput.js

This file was deleted.

Loading