legendgroup and other legend attrs #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmt0
force-pushed
the
legendgroup
branch
2 times, most recently
from
0152938 to
2b627f7
Compare
nicolaskruchten
suggested changes
Sep 9, 2018
| import Button from '../widgets/Button'; | ||
| import {PlusIcon} from 'plotly-icons'; | ||
|
|
||
| class UnconnectedLegendgroupCreator extends Component { |
There was a problem hiding this comment.
Let's generalize this into a GroupCreator with a prefix attr so we can immediately reuse it for stackgroup
| <NumericFraction label={_('Trace Opacity')} attr="opacity" /> | ||
| <PlotlySection name={_('Show in Legend')}> |
There was a problem hiding this comment.
Please rename section Legend and restore the Show in Legend label for the show/hide button.
| <NumericFraction label={_('Trace Opacity')} attr="opacity" /> | ||
| <PlotlySection name={_('Legend')}> | ||
| <ShowInLegend |
There was a problem hiding this comment.
is the groupcreator meant to be IN the ShowInLegend? If i set it to 'hide' I still see the groupcreator
|
💃 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #737