Skip to content

Traceselector styling #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2018
Merged

Traceselector styling #732

merged 4 commits into from
Sep 6, 2018

Conversation

dmt0
Copy link
Contributor

@dmt0 dmt0 commented Sep 5, 2018

addresses #731

@dmt0 dmt0 requested a review from nicolaskruchten September 5, 2018 19:02
@nicolaskruchten
Copy link
Contributor

💃

@dmt0 dmt0 force-pushed the traceselector-styling branch from 28c6157 to 50b36ad Compare September 5, 2018 20:03
@dmt0
Copy link
Contributor Author

dmt0 commented Sep 5, 2018

So flex-basis:0 thing that I've put before breaks IE. If I set it to auto at this point, color picker and symbol selector start to jump like they did before.

@nicolaskruchten
Copy link
Contributor

I'm not thrilled about the Percy diff here... ?

@nicolaskruchten
Copy link
Contributor

Can you please create a new PR from 1294ed3 to master and we'll get that merged ASAP and you can keep iterating on this PR? Tacking on commits after 💃 just kinda slows things down actually :)

@dmt0
Copy link
Contributor Author

dmt0 commented Sep 6, 2018

I'm just gonna remove "fix numeric inputs on IE" from this one - the rest are safe

@dmt0 dmt0 force-pushed the traceselector-styling branch from 50b36ad to d063676 Compare September 6, 2018 14:51
@dmt0 dmt0 merged commit b2386d8 into master Sep 6, 2018
@dmt0 dmt0 deleted the traceselector-styling branch September 6, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaskruchten nicolaskruchten Awaiting requested review from nicolaskruchten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmt0 @nicolaskruchten