Skip to content

move subplot-related widgets to subplot panel #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2018
Merged

Conversation

dmt0
Copy link
Contributor

@dmt0 dmt0 commented Aug 8, 2018

closes #580 and closes #624

@nicolaskruchten
Copy link
Contributor

@dmt0 please pull before force-pushing, if needed. I'm a 💃 on these changes if you are on my contribution!

Please note that even after we make these changes, #624 is not resolved, for example in this minimal example where I make a scatterpolar then a scatter and see the Radius field in the ... Scatter fold?!

image

@nicolaskruchten
Copy link
Contributor

OK, with my latest push this commit does close #624 with respect to Radius. There's an old r field in scatter for some reason, and there was a bug in TraceTypeSection which wasn't protecting us correctly.

@dmt0
Copy link
Contributor Author

dmt0 commented Aug 8, 2018

Looks awesome! 💃

@nicolaskruchten nicolaskruchten merged commit 410870e into master Aug 8, 2018
@nicolaskruchten nicolaskruchten deleted the subplot-attrs branch August 8, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type-specific fields appearing inappopriately Subplots for all trace types
2 participants