rangeslider/rangeselector UI #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaskruchten
commented
Mar 16, 2018
| if ( | ||
| !plotProps.isVisible && | ||
| context.fullContainer._id && | ||
| context.fullContainer._id.startsWith('x') |
There was a problem hiding this comment.
note to self: exclude 3d traces somehow, also should provide some message for multi and y axis selection
There was a problem hiding this comment.
Vera says to use _axisGroup ... note to self 2: should exclude Y and All from AxesSelector where appropriate, and hide the whole panel where appropriate
There was a problem hiding this comment.
will be done as part of #424
nicolaskruchten
force-pushed
the
rangeslider
branch
from
1943594 to
df34a8e
Compare
nicolaskruchten
force-pushed
the
rangeslider
branch
from
ede5cb0 to
da5fc2c
Compare
nicolaskruchten
changed the title
|
💃 💃 💃 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.