Account for long text #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpostlethwaite
approved these changes
Jan 4, 2018
|
or text-font could get smaller? for languages who's menus translate to really long words? |
|
but 💃 for this pr |
VeraZab
approved these changes
Jan 4, 2018
|
@VeraZab yeah ideally it'd be great to not adjust type size, as we're already pretty small as it stands. Most areas (fold titles, buttons, section headers, field labels) all work with long text as I tested it (they will just wrap and look ok). The sidebar is fixed at a small width, though, so wrapping won't really be possible (esp with 1 word long items). |
can we hyphenate aggressively? you're right that sidebar titles really do NOT want to be truncated... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to account for longer text in most areas. The only spot that I think could cause issue is on the sidebar. It's pretty fixed, and until we have actual examples of length of words, I am not sure what we should do about that. We could allow for larger sidebar based off of a language.
This pr will prevent text from overflowing in the title area of folds, adding an '...' to the end of the string when it starts to overflow:
This also passes className's down to the fold if you apply them on the component.