Update theming classes, theming document. #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about this!
I am modifying where we attach our variables. As I was theming parts of the Batch app, I wanted access to these variables in different parts outside of the editor so it could live as one cohesive thing. I've opted to change where we are attaching our variables from having them on
.plotly-editorto making a class named.plotly-editor--theme-providerso that if you want to use the variables in parts of your application outside of the editor, you can add this class and get access to the properties.Another solution is to just stick with using
:root{}, but I worry that we could crowd peoples own variables in their:root{}if they are also using css custom properties.