Add info message for area trace opacity #198
Conversation
src/components/containers/Section.js
Outdated
| const cannotSetTraceOpacity = | ||
| fullContainer.type === 'scatter' && | ||
| (fullContainer.fill !== 'none' || fullContainer.fill !== 'toself'); | ||
|
|
There was a problem hiding this comment.
@alexcjohnson is cannotSetTraceOpacity correct?
I feel like since there's an accordion menu for each trace in the editor, the rest of this logic doesn't apply:
https://github.com/plotly/plotly.js/blob/master/src/traces/scatter/clean_data.js#L24
There was a problem hiding this comment.
if we're looking at the trace from fullData, we should just be able to use the results of scatter/clean_data, ie fullContainer.type === 'scatter' && fullContainer.opacity === undefined, right? Because the multi-trace aspect of it is really important for alleviating confusion and you're right that you don't want to try and reconstruct that here.
There was a problem hiding this comment.
thanks! will do that
VeraZab
force-pushed
the
add-opacity-message
branch
from
28735ff to
f33b2ab
Compare
|
@bpostlethwaite @alexcjohnson can I merge? |
want to rebase while I look at it again? |
VeraZab
force-pushed
the
add-opacity-message
branch
from
8e18fe2 to
e7e9f03
Compare
closes: #70
