Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to cherry-pick.
(Other) Remarks:
Julia is the only (open source) language where no output (i.e. the plots) are shown. Is that intended?
I can't build the docs locally with Julia 1.11.3. Using the given Manifest.toml I receive various precompilation errors. Updating first to most recent packages and running
make html
I get variouserrors. (Maybe this is related to the previous point.)
missing links (to other parts of the docs)
plotlyjs.jl-docs/julia/shapes.md
Line 256 in 8a874cf
plotlyjs.jl-docs/julia/shapes.md
Line 545 in 8a874cf
(at least) the commands
add_hline!
,add_vline!
,add_hrect!
andadd_vrect!
aren't found when I search for them in the manual.I'd say at least every command should have a corresponding manual entry and should be findable by the search function.
Is it intended that 6 values of
x|yref
are given as chars, e.g.'x'
instead of as strings?I suspect that in
plotlyjs.jl-docs/julia/shapes.md
Line 447 in 8a874cf
the
"y4"
should be a"y2"
, right? If this is intended, I suggest to add a comment to the code.