Skip to content

Issue194 fixed #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Issue194 fixed #349

merged 4 commits into from
Aug 23, 2021

Conversation

gilbertogalvis
Copy link
Contributor

This PR fix the issue #194

For this I proposed a new plot option to control axis size called AxisEqual

code to test:

close all, clc
X = [1 3 0.5 2.5 2];
pie(X)
fig2plotly(gcf, 'offline', 0, 'AxisEqual', true);

Using before code results are as bellow

Screen Shot 2021-08-18 at 8 37 52 PM

Screen Shot 2021-08-18 at 8 38 58 PM

If 'AxisEqual' is not set or is set to false then the result is as bellow

Screen Shot 2021-08-18 at 8 43 13 PM

@VolKa79
Copy link

VolKa79 commented Aug 19, 2021

Colors and proportions are good but not getting numbers of percents aside pie
is194

@gilbertogalvis
Copy link
Contributor Author

Colors and proportions are good but not getting numbers of percents aside pie
is194

@VolKa79 please make sure following changes are set in the plotlyfig.m file you use

Screen Shot 2021-08-19 at 12 08 40 PM

@VolKa79
Copy link

VolKa79 commented Aug 19, 2021

Yes, done these updates.
is194_2

Can be the reason that I am running in offline mode ?
close all, clc
X = [1 3 0.5 2.5 2];
pie(X)
fig2plotly(gcf, 'offline', true, 'AxisEqual', true);

@gilbertogalvis
Copy link
Contributor Author

gilbertogalvis commented Aug 19, 2021

Yes, done these updates.
is194_2

Can be the reason that I am running in offline mode ?
close all, clc
X = [1 3 0.5 2.5 2];
pie(X)
fig2plotly(gcf, 'offline', true, 'AxisEqual', true);

Nou. Reason is you dont have updated the line #684. Look at the screenshot I shared with you.

I imagen you had some conflict and when you solve it that line was missed

Correct line is this

if ~strcmpi(plotclass, 'heatmap')

@VolKa79
Copy link

VolKa79 commented Aug 19, 2021

Yes, it works now
sorry for inattention

@gilbertogalvis
Copy link
Contributor Author

Yes, it works now
sorry for inattention

Don't worry my friend. Very glad that it works

@gilbertogalvis gilbertogalvis merged commit e8803ab into master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants