Skip to content

add what about dash section #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 23, 2020
Merged

add what about dash section #41

merged 12 commits into from
Mar 23, 2020

Conversation

jdamiba
Copy link
Contributor

@jdamiba jdamiba commented Mar 17, 2020

@jdamiba jdamiba requested a review from nicolaskruchten March 18, 2020 00:23

### What About Dash?

DashR is an open-source framework for building analytical applications, with no Javascript required, and it is tightly integrated with the Plotly graphing library. Everywhere in this page that you see fig, you can display the same figure in a Dash application by passing it to the figure argument of the Graph component from the built-in dashCoreComponents package like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll want some links and backticks etc in this paragraph too :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also "Dash for R" rather than DashR

library(dashHtmlComponents)

app <- Dash$new()
app$layout (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing <- ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not, we should remove the space before the (

@jdamiba
Copy link
Contributor Author

jdamiba commented Mar 19, 2020

@nicolaskruchten This is ready for review.


### What About Dash?

[Dash for R](https://dash.plot.ly/) is an open-source framework for building analytical applications, with no Javascript required, and it is tightly integrated with the Plotly graphing library. Everywhere in this page that you see `fig`, you can display the same figure in a Dash for R application by passing it to the `figure` argument of the [`Graph` component](https://dash.plot.ly/dash-core-components/graph) from the built-in `dashCoreComponents` package like this:
Copy link
Member

@chriddyp chriddyp Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Dash for R](https://dash.plot.ly/) is an open-source framework for building analytical applications, with no Javascript required, and it is tightly integrated with the Plotly graphing library. Everywhere in this page that you see `fig`, you can display the same figure in a Dash for R application by passing it to the `figure` argument of the [`Graph` component](https://dash.plot.ly/dash-core-components/graph) from the built-in `dashCoreComponents` package like this:
[Dash for R](https://dashr.plot.ly/) is an open-source framework for building analytical applications, with no Javascript required, and it is tightly integrated with the Plotly graphing library. Everywhere in this page that you see `fig`, you can display the same figure in a Dash for R application by passing it to the `figure` argument of the [`Graph` component](https://dashr.plot.ly/dash-core-components/graph) from the built-in `dashCoreComponents` package like this:

@nicolaskruchten
Copy link
Contributor

As we discovered, we need a link to the installation guide first otherwise people will not know how to install dash :)

dccGraph(figure=fig)
)

app$run_server()
Copy link
Contributor

@nicolaskruchten nicolaskruchten Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
app$run_server()
app$run_server(debug=TRUE, dev_tools_hot_reload=FALSE)

@nicolaskruchten
Copy link
Contributor

Just added the R version of Chris' comments from plotly/documentation#1654

Joseph Damiba and others added 3 commits March 23, 2020 12:40
@jdamiba
Copy link
Contributor Author

jdamiba commented Mar 23, 2020

I have updated the PR with the latest suggestions.

@nicolaskruchten
Copy link
Contributor

💃 !

@nicolaskruchten nicolaskruchten merged commit 7278d0d into master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants