-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Bullet Chart FF #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bullet Chart FF #872
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ff36387
added annotation dict func from facet_grid to utils
Kully 5b9ddaa
add bullet ff
Kully 939a8ba
fix text_color name
Kully 5796a9e
added list_options to utils
Kully bb15f6a
working except variable measures
Kully 8a5ea2b
enhance intermediate color function in colors.py
Kully 4599bc2
working ff
Kully beb6d18
optional tests
Kully 8ba62a2
added full test for bullet params
Kully 69bd30d
reworked bullet charts with bar traces
Kully 69a541d
not mutating data//pep8 in colors.py
Kully e74996c
adding test file to figure_factory repo
Kully 6da599f
adding **kwargs - broken state
Kully 79c67c7
finished chris comments and updated tests
Kully 9b9b578
remove json file and fixed test
Kully af9cb17
ensure hor and ver spacing is always float
Kully 6080d80
changelog and version number bump
Kully 082fdfd
few last comments
Kully dfd1b2c
pandas imported message to 'installed'
Kully a2b0ca0
rest of chris' comments
Kully ca9d37a
fix tests
Kully d0f5251
basestring to str
Kully File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a typo? i thought
tuple
returned a list (well, a tuple) of colors?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see how there's confusion.
If
colortype='tuple'
,lowcolor
andhighcolor
must be what I have called tuple(-like) colors i.e. tuples of the form (a,b,c) where a, b, c are between 0 and 1, where (0,0,0) == rgb(0,0,0), etc.If the input is
lowcolor=(0,0,0), highcolor=(1,1,1), n_colors=3
then the output is:[(0, 0, 0), (0.5, 0.5, 0.5), (1, 1, 1)]
If
colortype='rgb'
, then the list above will contain the rgb equivalent colors in a listThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this function will error if you input tuple-colors and colortype is set to
rgb
. Another thing to fix.