Skip to content

update graph_objs.py #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2017
Merged

update graph_objs.py #852

merged 3 commits into from
Oct 11, 2017

Conversation

cldougl
Copy link
Member

@cldougl cldougl commented Oct 9, 2017

@@ -1 +1 @@
__version__ = '2.0.16'
__version__ = '2.0.17'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've actually been doing semver wrong. Table is a new feature, so I believe that this should be 2.1.0 (http://semver.org/)

Copy link
Member Author

@cldougl cldougl Oct 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I thought we were only bumping if it was a new plotly.py specific feature but either way is fine for me

@chriddyp
Copy link
Member

chriddyp commented Oct 9, 2017

was this generated by a script or done by hand?

@cldougl
Copy link
Member Author

cldougl commented Oct 9, 2017

by script: make update_default_schema
https://github.com/plotly/plotly.py/blob/master/makefile#L19

@jackparmer
Copy link
Contributor

💃 looks like it will work to me. Once it's on pip I'm happy to take it for a spin on streambed

@cldougl cldougl merged commit a4402e9 into master Oct 11, 2017
@cldougl cldougl mentioned this pull request Oct 20, 2017
@nicolaskruchten nicolaskruchten deleted the updt_graph_ob branch June 19, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants