Skip to content

test and fix master #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 7, 2017
Merged

test and fix master #709

merged 5 commits into from
Mar 7, 2017

Conversation

chriddyp
Copy link
Member

@chriddyp chriddyp commented Mar 7, 2017

No description provided.

@chriddyp chriddyp changed the title Test sdist test and fix master Mar 7, 2017
@@ -58,3 +58,13 @@ test:
# since optional requirements is part of the test suite, we don't need to
# worry about testing that it *can* be imported in this case.
- $(! python -c "import plotly.figure_factory")

# test the distribution and a basic import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good idea

@chriddyp
Copy link
Member Author

chriddyp commented Mar 7, 2017

ready for review @cldougl and @Kully

CHANGELOG.md Outdated
## Added
- Dashboards can now be created using the API and uploaded to Plotly. Use `import plotly.dashboard_objs` to create a `Dashboard` object. You can learn more about `Dashboard` objects by running `help(plotly.dashboard_objs)` and `help(plotly.plotly.plotly.dashboard_ops)` for uploading and retrieving dashboards from the cloud.


## [2.0.2] - 2017-02-20
## [2.0.2] - 2017-02-20 [YANKED]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0.2 was the last stable version

2.0.3 and 2.0.4 were yanked and we'll need to release 2.0.5

CHANGELOG.md Outdated
@@ -4,12 +4,16 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [2.0.3] - 2017-03-06
## [2.0.4] - 2017-03-07
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this should be 2.0.5

@cldougl
Copy link
Member

cldougl commented Mar 7, 2017

💃 after straightening out changelog

CHANGELOG.md Outdated
@@ -4,16 +4,22 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [2.0.4] - 2017-03-07
## [2.0.5] - 2017-03-07
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kully
Copy link
Contributor

Kully commented Mar 7, 2017

💃

@chriddyp chriddyp merged commit 4b45341 into master Mar 7, 2017
@chriddyp chriddyp deleted the test-install branch March 7, 2017 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants