Skip to content

add changelog changes for Grid-accepting-dataframe #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2017

Conversation

Kully
Copy link
Contributor

@Kully Kully commented Jan 27, 2017

No description provided.

@Kully
Copy link
Contributor Author

Kully commented Jan 27, 2017

Man, I keep forgetting the CHANGELOG...
Regarding the now closed-and-merged #675 (review)

@theengineear can you review quickly?

Also, is this the proper protocol with version numbers? - do we only bump the version number right before we know we are going to update the pip package, so that it grabs the new version number?

@Kully Kully changed the title add changelog changes add changelog changes for Grid-accepting-dataframe Jan 27, 2017
@@ -2,6 +2,11 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yup putting this under unreleased is correct. When you do a version bump, you change this to reflect the version number. When you're sure it's up on PyPI, you can set the date for the release and create a new Git Tag/Release.

@@ -2,6 +2,11 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't done a good job of this in the past, but let's not use the term Updated. The guide we follow suggests only using:

  • Added
  • Changed
  • Deprecated
  • Removed
  • Fixed
  • Security

You should use Changed here.

@Kully
Copy link
Contributor Author

Kully commented Jan 27, 2017

@theengineear all 💃 ?

Copy link
Contributor

@theengineear theengineear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grrrrrrreat!

@theengineear
Copy link
Contributor

💃

@Kully Kully merged commit f60c65d into master Jan 27, 2017
@Kully Kully deleted the changelog-for-accept-dataframe branch January 27, 2017 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants