-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
add changelog changes for Grid-accepting-dataframe #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Man, I keep forgetting the CHANGELOG... @theengineear can you review quickly? Also, is this the proper protocol with version numbers? - do we only bump the version number right before we know we are going to update the |
@@ -2,6 +2,11 @@ | |||
All notable changes to this project will be documented in this file. | |||
This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|||
## [Unreleased] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 yup putting this under unreleased is correct. When you do a version bump, you change this to reflect the version number. When you're sure it's up on PyPI, you can set the date for the release and create a new Git Tag/Release.
@@ -2,6 +2,11 @@ | |||
All notable changes to this project will be documented in this file. | |||
This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|||
## [Unreleased] | |||
|
|||
### Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't done a good job of this in the past, but let's not use the term Updated
. The guide we follow suggests only using:
Added
Changed
Deprecated
Removed
Fixed
Security
You should use Changed
here.
@theengineear all 💃 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grrrrrrreat!
💃 |
No description provided.