Skip to content

Patch Figure to allow frames. #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

theengineear
Copy link
Contributor

We need frames for animations, this is a hack since they don’t exist in
the graph reference.

We need frames for animations, this is a hack since they don’t exist in
the graph reference.
@theengineear
Copy link
Contributor Author

@Kully merge this into yr branch if you want :) I didn't want to commit anything directly to yr branch just so you have full control of this.

Can you test this out and see if it will work for you? If you just want to mess around with it locally without merging, you can cherry-pick it like so:

git fetch origin
git cherry-pick d53c7ef715b1f0390435ad22147ae49a64d2e9cb
git reset HEAD^

That does the following:

  1. fetch the new things from this repo
  2. add this commit to your PR locally
  3. move your HEAD from that commit to the one before, moving those changes into your staged files

Be careful about git reset HEAD^, that undoes one (^) commit from the current commit yr pointing to in git.

Feel free to copy/paste if that feel simpler :)

Kully added a commit that referenced this pull request Oct 20, 2016
@Kully
Copy link
Contributor

Kully commented Oct 25, 2016

Closing since the added code lines here have been manually entered into the referenced PR #584

@Kully Kully closed this Oct 25, 2016
@Kully Kully deleted the patch-figure-for-frames branch October 25, 2016 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants