Skip to content

Add caching of optional requirements #5022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Add caching of optional requirements #5022

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d5b5aeb
Add caching of optional requirements
marthacryan Feb 7, 2025
86d192a
Merge branch 'unpin-requirements' of github.com:plotly/plotly.py into…
marthacryan Feb 10, 2025
6087e3c
Debug
marthacryan Feb 10, 2025
9039225
Merge branch 'unpin-requirements' of github.com:plotly/plotly.py into…
marthacryan Feb 10, 2025
06b05d0
Debug
marthacryan Feb 10, 2025
40c4547
Set cache key to be specific to python version
marthacryan Feb 11, 2025
f07f2ca
Fix filepath of requirements file
marthacryan Feb 11, 2025
84767ac
Try to fix caching
marthacryan Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ commands:
type: string
steps:
- checkout
- restore_cache:
key: optional-dependencies-{{ checksum "test_requirements/requirements_optional.txt" }}-{{ checksum parameters.py }}
- browser-tools/install-chrome
- browser-tools/install-chromedriver
- run:
Expand All @@ -46,6 +48,12 @@ commands:
cd js
npm ci
npm run build

- save_cache:
paths:
- venv
key: optional-dependencies-{{ checksum "test_requirements/requirements_optional.txt" }}-{{ checksum parameters.py }}

- run:
name: Test core
command: |
Expand All @@ -71,7 +79,7 @@ commands:
pytest tests/test_io
no_output_timeout: 20m
- run:
name: Test dependencdies not imported
name: Test dependencies not imported
command: |
. venv/bin/activate
python -m pytest -x test_init/test_dependencies_not_imported.py
Expand Down