-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Unpin test requirements #5019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin test requirements #5019
Conversation
6862255
to
c2af57b
Compare
Co-authored-by: Emily KL <[email protected]>
… unpin-requirements
faa3d7c
to
d282c49
Compare
be9ae8f
to
2a63724
Compare
Narwhals is already bundled with plotly.py, so users shouldn't have to install it themselves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marthacryan LGTM once my final comments are addressed! 🚀
This is a huge win for maintainability.
A few big-picture thoughts that could be addressed in another PR:
-
IMO we should bring back the no-numpy job (to prevent
numpy
dependency from accidentally slipping into core Plotly.py) -
If we're testing
pandas<2
with Python 3.9, should we also testpandas<2
for other Python versions? Probably worth a discussion.
d9f0a5f
to
d3de0b1
Compare
plotly/tools.py