Skip to content

chore: update comment about needs_interchanging #4895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024
Merged

chore: update comment about needs_interchanging #4895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/python/plotly/plotly/express/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,9 +1486,8 @@ def build_dataframe(args, constructor):
# PySpark to pandas.
is_pd_like = False

# Flag that indicates if data_frame requires to be converted to arrow via the
# dataframe interchange protocol.
# True if Ibis, DuckDB, Vaex or implements __dataframe__
# Flag that indicates if data_frame needs to be converted to PyArrow.
# True if Ibis, DuckDB, Vaex, or implements __dataframe__
needs_interchanging = False

# If data_frame is provided, we parse it into a narwhals DataFrame, while accounting
Expand Down