Modify template generator to automatically add new map traces and subplots
#4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #4879 for discussion. 1. Move material from `packages/python/plotly/templategen/__init__.py` to new file `packages/python/plotly/templategen/__main__.py` so that we can run `python -m templategen` from the `packages/python/plotly` directory. 2. Modify `packages/python/plotly/templategen/utils/__init__.py` to change `heatmapgl` reference to `heatmap`. 3. Run `python -m templategen` to generate new versions of the following files: - `packages/python/plotly/plotly/package_data/templates/ggplot2.json` - `packages/python/plotly/plotly/package_data/templates/plotly.json` - `packages/python/plotly/plotly/package_data/templates/plotly_dark.json` - `packages/python/plotly/plotly/package_data/templates/plotly_white.json` - `packages/python/plotly/plotly/package_data/templates/seaborn.json` - `packages/python/plotly/plotly/package_data/templates/simple_white.json`
|
does this replace #4880 ? |
|
The only way I can think of to test the templates themselves is to add something that parses the JSON and looks at the structure, but I don't think that would add much value, since it would basically be cloning the generator code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4879.
See #4879 for discussion.
packages/python/plotly/templategen/__init__.pyto new filepackages/python/plotly/templategen/__main__.pyso that we can runpython -m templategenfrom thepackages/python/plotlydirectory.packages/python/plotly/templategen/utils/__init__.pyto changeheatmapglreference toheatmap.python -m templategento generate new versions of the following files:packages/python/plotly/plotly/package_data/templates/ggplot2.jsonpackages/python/plotly/plotly/package_data/templates/plotly.jsonpackages/python/plotly/plotly/package_data/templates/plotly_dark.jsonpackages/python/plotly/plotly/package_data/templates/plotly_white.jsonpackages/python/plotly/plotly/package_data/templates/seaborn.jsonpackages/python/plotly/plotly/package_data/templates/simple_white.json