-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Unpin jupyterlab version in optional requirements #4866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -45,7 +45,7 @@ scipy | |||
|
|||
## jupyter ## | |||
jupyter | |||
jupyterlab ~=3.0 # To package js extension as federated module | |||
jupyterlab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marthacryan for the quick fix.
Thanks for the fix! Can we please get a new release of plotly in PyPI that includes this fix? Interested in integrating it with JupyterLab 4 and I found this is what's blocking it. Thanks! |
@filbranden We're about to do a major release so this should all be on PyPi soon! But I believe JupyterLab 4 should work with Plotly? Where are you seeing issues with integrating? |
Thank you @marthacryan! This is what I'm seeing:
And the
|
Installing Granted, not sure if this warning amounts to any issues in production, but from that warning I tracked down this PR so that's how I got here 😃 Knowing a new release is forthcoming is much appreciated! |
@filbranden Thanks for the context! Is this affecting the behavior of plotly in your actual notebook editor? The |
No in that case nevermind, I just assumed there was something wrong with it based on that warning from this command, if everything is supposed to work correctly then that should be the case. Thanks for following up! |
No problem! Thanks for reaching out |
The JupyterLab version was pinned in the optional requirements because JupyterLab 3 allowed for both npm and python packaged extensions, while JupyterLab 4 dropped support for npm extensions. Now that #4779 is merged, we no longer need to support npm extensions, so we can unpin this dependency.