Skip to content

Unpin jupyterlab version in optional requirements #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Unpin jupyterlab version in optional requirements #4866

merged 1 commit into from
Nov 12, 2024

Conversation

marthacryan
Copy link
Collaborator

The JupyterLab version was pinned in the optional requirements because JupyterLab 3 allowed for both npm and python packaged extensions, while JupyterLab 4 dropped support for npm extensions. Now that #4779 is merged, we no longer need to support npm extensions, so we can unpin this dependency.

@@ -45,7 +45,7 @@ scipy

## jupyter ##
jupyter
jupyterlab ~=3.0 # To package js extension as federated module
jupyterlab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marthacryan for the quick fix.

@archmoj archmoj merged commit 366b017 into master Nov 12, 2024
5 checks passed
@archmoj archmoj deleted the unpin-jl branch November 12, 2024 21:31
@filbranden
Copy link

filbranden commented Nov 12, 2024

Thanks for the fix! Can we please get a new release of plotly in PyPI that includes this fix? Interested in integrating it with JupyterLab 4 and I found this is what's blocking it. Thanks!

@marthacryan
Copy link
Collaborator Author

@filbranden We're about to do a major release so this should all be on PyPi soon! But I believe JupyterLab 4 should work with Plotly? Where are you seeing issues with integrating?

@filbranden
Copy link

Thank you @marthacryan!

This is what I'm seeing:

$ jupyter labextension list
...
        jupyterlab-plotly v5.24.1 enabled  X
...
   The following extensions may be outdated or specify dependencies that are incompatible with the current version of jupyterlab:
        jupyterlab-plotly

   If you are a user, check if an update is available for these packages.
   If you are a developer, re-run with `--verbose` flag for more details.

And the --verbose output is:

"[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab        Extension              Package
>=2.0.0 <3.0.0    >=1.2.3 <2.0.0         @lumino/messaging
>=2.3.1-alpha.0 <3.0.0>=1.8.1 <2.0.0         @lumino/widgets

@filbranden
Copy link

Installing dist/plotly-5.24.1+352.gd31c72885-py3-none-any.whl built from trunk fixes this warning

Granted, not sure if this warning amounts to any issues in production, but from that warning I tracked down this PR so that's how I got here 😃

Knowing a new release is forthcoming is much appreciated!

@marthacryan
Copy link
Collaborator Author

marthacryan commented Nov 12, 2024

@filbranden Thanks for the context! Is this affecting the behavior of plotly in your actual notebook editor? The jupyter labextension list output is a remnant of older builds of JupyterLab 4, but the actual behavior I've seen in JupyterLab 4 has been working. I'm interested if that's broken for you! Glad to hear that the wheel is working though :D

@filbranden
Copy link

No in that case nevermind, I just assumed there was something wrong with it based on that warning from this command, if everything is supposed to work correctly then that should be the case. Thanks for following up!

@marthacryan
Copy link
Collaborator Author

No problem! Thanks for reaching out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants