Skip to content

add deprecation notice for mapbox traces #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
+255 −833
Closed

add deprecation notice for mapbox traces #4783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8cd51cc
add deprecation notice for mapbox traces
archmoj Oct 7, 2024
f983b46
Merge branch 'master' into mapbox-deprecated-warning
archmoj Oct 31, 2024
4005169
WIP
archmoj Nov 5, 2024
adb71b7
generate deprecation notices using codegen and update plotly.js from …
archmoj Nov 5, 2024
83d3429
Update packages/python/plotly/codegen/datatypes.py
archmoj Nov 6, 2024
1b63859
update messages
archmoj Nov 6, 2024
03fb296
Merge branch 'master' into mapbox-deprecated-warning
archmoj Nov 6, 2024
6b9c1e3
use warn
archmoj Nov 7, 2024
021586c
move warnings to map box class inits
archmoj Nov 11, 2024
98b5119
Merge branch 'master' into mapbox-deprecated-warning
archmoj Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/python/plotly/plotly/graph_objs/_choroplethmapbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@


class Choroplethmapbox(_BaseTraceType):
print(
Copy link
Member

@ndrezn ndrezn Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a proper warning rather than print statements

"*choroplethmapbox* trace is deprecated!",
"Please consider switching to the *choroplethmap* trace type and `map` subplots.",
"Learn more at: https://plotly.com/javascript/maplibre-migration/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All links should point to the Python documentation: https://plotly.com/python/mapbox-to-maplibre/

)

# class properties
# --------------------
Expand Down
5 changes: 5 additions & 0 deletions packages/python/plotly/plotly/graph_objs/_densitymapbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@


class Densitymapbox(_BaseTraceType):
print(
"*densitymapbox* trace is deprecated!",
"Please consider switching to the *densitymap* trace type and `map` subplots.",
"Learn more at: https://plotly.com/javascript/maplibre-migration/",
)

# class properties
# --------------------
Expand Down
5 changes: 5 additions & 0 deletions packages/python/plotly/plotly/graph_objs/_scattermapbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@


class Scattermapbox(_BaseTraceType):
print(
"*scattermapbox* trace is deprecated!",
"Please consider switching to the *scattermap* trace type and `map` subplots.",
"Learn more at: https://plotly.com/javascript/maplibre-migration/",
)

# class properties
# --------------------
Expand Down