Violin #471
Violin #471
Conversation
|
|
|
ping @empet, who wrote the 🎻 vignette this is based on |
Can we please take out the color bar by default and use qualitative coloring? Sequential coloring by Looks like this seaborn violin plot is may be coloring sequentially based on mean: I personally like the style of these a lot:
|
|
I will be adding a colorscale that works on statistic parameters, user inputted stats on the data, etc. |
| q2 = np.percentile(x, 50, interpolation='linear') | ||
| q1 = np.percentile(x, 25, interpolation='lower') | ||
| q3 = np.percentile(x, 75, interpolation='higher') | ||
| IQR = q3 - q1 |
There was a problem hiding this comment.
🐄 why the CAPS on this? Let's try to reserve those for module constants.
|
I commented out the last all_args test just in case I have to redo the function once again and need to rewrite the New Docs, new examples in doc string, and most importantly, you can input a dictionary of stats assigned to values in the indexing column and get some colorscale stuff happening. |
|
^This is colorscaling on median |
|
Nice! Lookin' promising! I think the colorscale should always work off On Mon, Jun 6, 2016 at 3:40 PM, Adam Kulidjian [email protected]
|
|
@Kully I think your entry method could use a little refactoring. I repeats a lot of the same color validations. A good first step would be to create a Also, in general, I think some of your function calls and error messages take up one or two more lines than are probably necessary. That's not such a big deal, but just something I noticed. |
| un_rgb_color = (color[0]/(255.0), | ||
| color[1]/(255.0), | ||
| color[2]/(255.0)) | ||
| if isinstance(colors, tuple): |
There was a problem hiding this comment.
🐄 This is pretty un-duck-type-y. What's preventing a future tuple of tuples here?
|
@Kully overall, I'm mostly just psyched to see these violin plots! That said it'd be great if you could address two things and I'll give this PR a final review:
Thanks for cranking through all these new |
Thanks for the review. |
I will need some help approaching this. |
|
@theengineear Help! =) |
|
@theengineear I was right! |
| #foo = FigureFactory._n_colors(foo[0], | ||
| # foo[1], | ||
| # len(intervals)) | ||
| #theme = FigureFactory._label_rgb(foo) |
There was a problem hiding this comment.
🐈 Did you mean to commit this?
…] == ','...' line in _unlabel_rgb
|
@theengineear Ready for takeoff? |
|
Yep 💃 after tests pass! |
|
🚀 |
@jackparmer @theengineear @cldougl
First Pull Request for Violin Plots.
Lot of the work is done. Some notes:
-tests need to be added
-organize some of the color testing a little better
-I changed some of the preexisting color-converting functions to allow use for singleton color-strings
Right now, colorscaling just colors multiple violin plots from left to right with equal weight across. Good ideas could be colorscaling by some of the stat_params including median, lowest value, quartiles, etc.