Skip to content

fix typo in error message formatting in process_args_into_dataframe #4658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ndrwrbgs
Copy link
Contributor

@ndrwrbgs ndrwrbgs commented Jul 9, 2024

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

A couple issues when following contributing.md:

  1. the python packages appear to be floating and installed numpy at >=2, which did not work; the tests failed with deprecation of np.NaN. I'd submit a change but worry about how much backwards compatibility with numpy that might break so instead I forced my numpy down to <2.
  2. There were also some dependencies for tests which were not included in optional_requirements.txt: these included at least scikit-image statsmodels polars orca -- I resorted to testing just packages/python/plotly/plotly/tests/test_core to work around this.
  3. Finally, one tests wrote out the file packages/python/plotly/plotly/tests/test_orca/test_sg_scraper.html which was not git ignored -- though as a new contributor, I'm not sure if I missed something, the file isn't meant to be ignored, or if it's alright to add an ignore for it.

@gvwilson gvwilson self-assigned this Jul 19, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added community community contribution fix fixes something broken documentation written for humans labels Aug 13, 2024
@gvwilson gvwilson added the P2 considered for next cycle label Aug 13, 2024
@gvwilson gvwilson assigned marthacryan and unassigned LiamConnors Aug 23, 2024
@ndrwrbgs
Copy link
Contributor Author

Thanks in advance for the review @marthacryan

Copy link
Collaborator

@marthacryan marthacryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marthacryan marthacryan merged commit c643152 into plotly:master Oct 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution documentation written for humans fix fixes something broken P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants