Fix broken links #4618
Merged
Fix broken links #4618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Full build failing: #4619 |
Closed
gvwilson
reviewed
May 31, 2024
| @@ -36,7 +36,7 @@ help: | |||
| # Remove files which were added only for docstring generation | |||
| rm ../../packages/python/plotly/plotly/colors/diverging.py ../../packages/python/plotly/plotly/colors/sequential.py ../../packages/python/plotly/plotly/colors/qualitative.py ../../packages/python/plotly/plotly/colors/cyclical.py ../../packages/python/plotly/plotly/colors/colorbrewer.py ../../packages/python/plotly/plotly/colors/carto.py ../../packages/python/plotly/plotly/colors/cmocean.py | |||
| rm ../../packages/python/plotly/plotly/express/colors/diverging.py ../../packages/python/plotly/plotly/express/colors/sequential.py ../../packages/python/plotly/plotly/express/colors/qualitative.py ../../packages/python/plotly/plotly/express/colors/cyclical.py ../../packages/python/plotly/plotly/express/colors/colorbrewer.py ../../packages/python/plotly/plotly/express/colors/carto.py ../../packages/python/plotly/plotly/express/colors/cmocean.py | |||
| rename 's/graph_objs/graph_objects/' _build/html/*.html _build/html/generated/*.html | |||
| rename 's/graph_objs/graph_objects/' _build/html/*.html _build/html/generated/*.html _build/html/generated/generated/*.html | |||
There was a problem hiding this comment.
I don't understand why generated/generated but I trust you :-)
I'll try and fix that first as we'll need to fix it to do the next Plotly.py release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have these links on the reference docs
That go here: https://plotly.com/python-api-reference/generated/generated/plotly.graph_objects.Figure.html
But the names in the built api docs are different.
https://github.com/plotly/plotly.py-docs/tree/gh-pages/generated/generated
We are renaming everything else to
graph_objectsexcept these.This PR should fix the links, but I need to investigate more why these are in a different directory and if they should be included.