Skip to content

added UTF-8 encoding to the Jinja2 template example #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

rl-utility-man
Copy link
Contributor

I followed this example and got nonsense characters instead of negative signs because I failed to specify UTF-8 encoding, as discussed in #4118 This succinct edit specifies UTF-8 and documents the need to do so. I also specified a viewport following modern HTML standards -- although I do not feel strongly that doing so is strictly necessary.

I followed this example and got nonsense characters instead of negative signs because I failed to specify UTF-8 encoding, as discussed in plotly#4118
@rl-utility-man
Copy link
Contributor Author

@LiamConnors Coding-with-Adam is there anything more I need to do to get this problem fix reviewed? Rob

@LiamConnors
Copy link
Member

Thanks @rl-utility-man. Just going to merge the latest changes into this branch to get the tests passing

@LiamConnors LiamConnors self-requested a review March 14, 2024 13:56
Copy link
Member

@LiamConnors LiamConnors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the PR @rl-utility-man

@LiamConnors LiamConnors merged commit 71d74a4 into plotly:doc-prod Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants