Skip to content

Update Plotly.js version to 2.24.2 #4252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Conversation

LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Jun 16, 2023

Update Plotly.js version to 2.24.2

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

-->

@LiamConnors LiamConnors requested a review from alexcjohnson June 16, 2023 18:11
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@alexcjohnson
Copy link
Collaborator

@LiamConnors do you understand the test failure? Looks like /packages/javascript/jupyterlab-plotly/package-lock.json needs to be updated as well?

@LiamConnors
Copy link
Member Author

@LiamConnors do you understand the test failure? Looks like /packages/javascript/jupyterlab-plotly/package-lock.json needs to be updated as well?

Yeah, looks like I didn't commit it or it wasn't there when I ran updateplotlyjs the first time. Ran it again and have added it now.

@LiamConnors LiamConnors merged commit 696c30b into master Jun 22, 2023
@LiamConnors LiamConnors deleted the update-plotly-js-2-24-2 branch June 22, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants