Skip to content

Be more forgiving when anything with opening a webbrowser fails #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 4, 2023
Merged

Be more forgiving when anything with opening a webbrowser fails #4161

merged 12 commits into from
Jun 4, 2023

Conversation

bartbroere
Copy link
Contributor

@bartbroere bartbroere commented Apr 15, 2023 •
edited
Loading

This (hopefully) fixes an issue I encountered with Starboard Notebook. I'll link the issue here.

@bartbroere bartbroere mentioned this pull request Apr 15, 2023
Closed
@bartbroere bartbroere changed the title [WIP] Be more forgiving when anything with opening a webbrowser fails Be more forgiving when anything with opening a webbrowser fails Apr 25, 2023
@bartbroere
Copy link
Contributor Author

bartbroere commented Apr 25, 2023 •
edited
Loading

@jonmmease I think this is ready for review. Since you have written most of the file I touched, I'm tagging you, but feel free to nominate someone else of course.

I don't fully understand the failing release build, but I don't suspect I am causing it.

Update: I hovered over your name and it said "Former Chief Scientist at Plotly", so I'm not entirely sure whether you review pull requests still. Maybe let's also tag @chriddyp 😇

@jonmmease
Copy link
Contributor

Hi @bartbroere, I'm not a maintainer of plotly projects any more, but FWIW these changes look reasonable to me!

@alexcjohnson
Copy link
Collaborator

@bartbroere the code change looks great, thanks! Just a couple of comments on the tests.

@bartbroere
Copy link
Contributor Author

Thanks for the commit bringing it up to date. I might have some time tonight (GMT+2) to finish this PR and apply the feedback.

@bartbroere
Copy link
Contributor Author

@alexcjohnson I think it's ready for merge now

alexcjohnson
alexcjohnson approved these changes Jun 4, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Thanks @bartbroere, looks great!

@alexcjohnson alexcjohnson merged commit a255c63 into plotly:master Jun 4, 2023
@bartbroere bartbroere mentioned this pull request Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartbroere @jonmmease @alexcjohnson