Skip to content

allow non-string extras in flaglist attributes #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 14, 2022
Merged

allow non-string extras in flaglist attributes #3749

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e6a9a4
allow non-string extras in flaglist attributes
alexcjohnson May 26, 2022
c4031df
lint
alexcjohnson May 26, 2022
6d2fb4d
changelog for non-string flaglist extras
alexcjohnson May 26, 2022
ef3a3eb
fix circleci url in get_latest_publish_build_info
alexcjohnson May 26, 2022
f8ec53a
Merge branch 'master' into non-string-flaglist-extras
nicolaskruchten Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/python/plotly/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def get_latest_publish_build_info(repo, branch):

url = (
r"https://circleci.com/api/v1.1/project/github/"
r"{repo}/tree/{branch}?limit=10000\&filter=completed"
r"{repo}/tree/{branch}?limit=100&filter=completed"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I remove the \ that makes its way into the final URL but before changing the limit value, this returns:

{
  "message" : "limit must be between 0 and 100"
}

I don't know what set of jobs this was returning when the \ was there, looked recent but somehow didn't include any publish-dist jobs. 🤷 anyway now it seems to work locally.

).format(repo=repo, branch=branch)

branch_jobs = request_json(url)
Expand Down