Smoothing being applied in the "unnoised" data #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The smoothening was being applied in y, and not in y_noise. That makes no sense.
nicolaskruchten
force-pushed
the
doc-prod
branch
from
1a182ff to
cbe41e6
Compare
gvwilson
changed the title
|
@alexcjohnson can you please tell me if the commit comment makes sense? |
alexcjohnson
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Good catch @mateomontero01 - and apologies for not noticing your PR earlier! Yes of course, the whole point here is what this filter does to noisy data, not to the underlying smooth curve. 💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoothening was being applied in y, and not in y_noise. That makes no sense.