-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Doc prod #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc prod #3079
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -231,7 +231,7 @@ fig.show() | |
|
||
### Automatic contrast rescaling in `px.imshow` | ||
|
||
When `zmin` and `zmax` are not specified, the `contrast_rescaling` arguments determines how `zmin` and `zmax` are computed. For `contrast_rescaling='minmax'`, the extrema of the data range are used. For `contrast_rescaling='infer'`, a heuristic based on the data type is used: | ||
When `zmin` and `zmax` are not specified, the `contrast_rescaling` arguments determines how `zmin` and `zmax` are computed. For `contrast_rescaling='minmax'`, the extreme of the data range are used. For `contrast_rescaling='infer'`, a heuristic based on the data type is used: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is the only one I disagree with... "extrema" is the correct latin word here although "extremes" would be less confusing to some ;) |
||
- for integer data types, `zmin` and `zmax` correspond to the extreme values of the data type, for example 0 and 255 for `uint8`, 0 and 65535 for `uint16`, etc. | ||
- for float numbers, the maximum value of the data is computed, and zmax is 1 if the max is smaller than 1, 255 if the max is smaller than 255, etc. (with higher thresholds 2**16 - 1 and 2**32 -1). | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ jupyter: | |
version: 3.6.8 | ||
plotly: | ||
description: Add linear Ordinary Least Squares (OLS) regression trendlines or | ||
non-linear Locally Weighted Scatterplot Smoothing (LOEWSS) trendlines to scatterplots | ||
non-linear Locally Weighted Scatterplot Smoothing (LOWESS) trendlines to scatterplots | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. again, very impressive catch! |
||
in Python. | ||
display_as: statistical | ||
language: python | ||
|
@@ -76,4 +76,4 @@ import plotly.express as px | |
df = px.data.gapminder().query("year == 2007") | ||
fig = px.scatter(df, x="gdpPercap", y="lifeExp", color="continent", trendline="lowess") | ||
fig.show() | ||
``` | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very impressed that the spell-checking finds this mistake but ignores the
stepss
on the same line! How does this work? Are you manually reviewing the changes before submitting the PRs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the comments @nicolaskruchten. No advanced NLP used here, but very basic NLP stuff. Firstly I have a corpus of english words with me. In my second step I create a corpus from all the documents in the project (lets call this plotly corpus). Then I count all the words in the plotly corpus. Then I add all words in plotly corpus having word count greater than a fixed threshold to the english ones. This step ensures that the programming jargon is not counted as a spelling error.
Now all words which don't exist in the final corpus are treated as errors. If any document contains error words, my script just prints out the filename and the errored word. I go through this and fix them manually.
maybe the document contained the word
stepss
a lot of times. Thus it isnt treated as an errorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting!
stepss
is definitely not anywhere else, or shouldn't be. Its inclusion in this line of the changelog is specifically to point out that we made a mistake and had to fix it ;)Either way, thanks again for the contribution :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is lot of manual work involved. I go through the present sentence understand the context and then read the correction suggestion and take my call.