Default facet_{row,col}_spacing now based on fraction #2846
Conversation
Computed as some fraction divided by the number of rows or number of columns respectively.
Here we make sure test_facets passes and so use the sizes it is expecting.
|
I'll take a look but mostly for that issue I was hoping for a clearer error message so the user could fix things :) |
|
I'm pretty sure I would consider this a breaking change, unfortunately... I added the option to allow the users to do this externally if they like because I didn't think I could safely do this computation for the wide variety of height/width rows/cols possibilities :) |
|
My additional thought here is that the problem is to tune the gap in percentage terms such that the physical gap is of a reasonable size, which is not something we can do without either assuming what the physical dimensions of the plot are, or having the user provide them. So we would compute the vertical gap as a function of the height of the figure and the number of row-facets, say. We could just assume the height is whatever the template default is, perhaps? |
|
Hi - we are trying to tidy up the stale issues and PRs in Plotly's public repositories so that we can focus on things that are still important to our community. Since this one has been sitting for several years, I'm going to close it; if it is still a concern, please add a comment letting us know what recent version of our software you've checked it with so that I can reopen it and add it to our backlog. Thanks for your help - @gvwilson |
Computed as some fraction divided by the number of rows or number of
columns respectively.
Calls for some discussion as I have not used it in all places where a default might be useful, I have just tried to close #2026 .