shapes on subplots #2161
shapes on subplots #2161
Conversation
doc/python/shapes.md
Outdated
| from plotly.subplots import make_subplots | ||
|
|
||
| # Create Subplots | ||
| fig = make_subplots(rows=2, cols=2, start_cell='bottom-left') |
There was a problem hiding this comment.
So why do we need to change the start_cell here? I would need an explanation, so probably the tutorial too ;-)
There was a problem hiding this comment.
It looked good to me also without changing the start_cell, so I'd suggest to limit the complexity here unless of course I am missing something.
|
Thank you @Mahdis-z ! Just a couple of suggestions and then we can merge :-). |
Thanks for the thorough review @emmanuelle |
| @@ -638,6 +638,34 @@ fig.update_layout( | |||
| fig.show() | |||
| ``` | |||
|
|
|||
| #### Adding Shapes to Subplots | |||
| Here we use the different axes (`x1`, `x2`) created by `make_subplots` as reference in order to draw shapes in figure subplots. | |||
| ```python | |||
There was a problem hiding this comment.
maybe you need a blank line before the python cell here, not sure (please check)
There was a problem hiding this comment.
would try, not sure why CI fails
|
thank you 💃 ! |
|
The orca failure here should resolve itself soon when pytest upgrades, or if we downgrade pytest.. |
|
This one is good to go @Mahdis-z you can merge it (the orca failure has already been fixed in another merged commit). |
No description provided.